---
title: '22745'
pageLayout: default
tags:
  - pr-reviews
  - feat-
  - sig-
slug: thoughts/inference/vllm-prs/22745
permalink: https://aarnphm.xyz/thoughts/inference/vllm-prs/22745.md
generator:
  quartz: v4.6.0
  hostedProvider: Cloudflare
  baseUrl: aarnphm.xyz
full: https://aarnphm.xyz/llms-full.txt
---
# [#22745](https://github.com/aarnphm/aarnphm.github.io/issues/22745) \[CI\]\[Nixl\] Check kv cache layout during handshake

[vllm-project/vllm#22745](https://github.com/vllm-project/vllm/pull/22745) · NickLucche · MERGED · created 2025-08-12T15:33:11Z · merged 2025-08-12T19:53:53Z

Adding tests and an assert to this hotfix [vllm-project/vllm#22663](https://github.com/vllm-project/vllm/pull/22663) to make sure it that, if we break it, we know we have broken it.

---

## comments

**github-actions** (2025-08-12T15:33:19Z):

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at <https://slack.vllm.ai> to discuss your PR in <ref slug="tags/pr-reviews">, coordinate on features in <ref slug="tags/feat-"> channels, or join special interest groups in <ref slug="tags/sig-"> channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run `fastcheck` CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your `fastcheck` build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping `simon-mo` or `khluu` to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add `ready` label to the PR or enable auto-merge.

🚀

**NickLucche** (2025-08-12T17:43:33Z):

Unrelated failures:



```
[2025-08-12T17:41:14Z] ERROR entrypoints/openai/test_skip_tokenizer.py::test_single_request[True-christian-pinto/Prithvi-EO-2.0-300M-TL-VLLM] - RuntimeError: Server exited unexpectedly.
[2025-08-12T17:41:14Z] ERROR entrypoints/openai/test_skip_tokenizer.py::test_single_request[False-christian-pinto/Prithvi-EO-2.0-300M-TL-VLLM] - RuntimeError: Server exited unexpectedly.
```

